Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reference] Fix external links #686

Merged
merged 3 commits into from
Mar 7, 2025
Merged

[reference] Fix external links #686

merged 3 commits into from
Mar 7, 2025

Conversation

colleenmcginnis
Copy link
Contributor

In the migration tool, external URLs that contained .html were incorrectly modified to use .md.

To (attempt) to fix these links:

  1. I ran a script to find URLs that started with http (i.e. is not an internal or cross-repo link) and included .md somewhere in the URL.
  2. Then I ran all the resulting URLs through an external link-checker.
    i. If I got a 200 status code back, I didn't do anything to the link.
    ii. If I got a 404 status code back, I swapped out the .md with .html.
  3. I reran the link-checker to make sure all the updated links were now returning 200.

@colleenmcginnis colleenmcginnis requested a review from lcawl March 6, 2025 01:05
@colleenmcginnis colleenmcginnis self-assigned this Mar 6, 2025
@bmorelli25
Copy link
Member

bmorelli25 commented Mar 6, 2025 •
edited
Loading

I see a few missing. Maybe the conflict has something to do with it?

  1. https://jolokia.org/reference/html/agents.md 🫱 https://github.com/search?q=repo%3Aelastic%2Fdocs-content%20https%3A%2F%2Fjolokia.org%2Freference%2Fhtml%2Fagents.md&type=code
  2. rabbitmq.com 🫱 https://github.com/search?q=repo%3Aelastic%2Fdocs-content+http%3A%2F%2Fwww.rabbitmq.com&type=code
  3. https://uwsgi-docs.readthedocs.io/en/latest/StatsServer.md 🫱 https://github.com/search?q=repo%3Aelastic%2Fdocs-content+https%3A%2F%2Fuwsgi-docs.readthedocs.io%2Fen%2Flatest%2FStatsServer.md&type=code

leemthompo
leemthompo approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@colleenmcginnis colleenmcginnis enabled auto-merge (squash) March 7, 2025 15:44
@colleenmcginnis colleenmcginnis merged commit df8d196 into main Mar 7, 2025
3 of 4 checks passed
@colleenmcginnis colleenmcginnis deleted the fix-external-links-reference branch March 7, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo approved these changes

@lcawl lcawl Awaiting requested review from lcawl

Assignees

@colleenmcginnis colleenmcginnis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colleenmcginnis @bmorelli25 @leemthompo